feat: Expose important library versions#7713
Merged
Merged
Conversation
Member
Author
|
@rjsparks is this implementation going in the correct direction? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7713 +/- ##
==========================================
+ Coverage 88.78% 88.95% +0.16%
==========================================
Files 296 303 +7
Lines 41320 41277 -43
==========================================
+ Hits 36687 36717 +30
+ Misses 4633 4560 -73 ☔ View full report in Codecov by Sentry. |
Member
|
Yes - these seems reasonable. |
Member
|
@kesara - do you want to continue to pursue this? |
Member
Author
Yes. I will. Sorry, I missed your reply during meeting. |
Update `/api/version` to include
```
"other": {
"xml2rfc": "<version>",
"weasyprint": "<version>"
},
```
Fixes ietf-tools#3415
kesara
marked this pull request as ready for review
November 3, 2024 12:24
rjsparks
reviewed
Nov 5, 2024
rjsparks
reviewed
Nov 19, 2024
rjsparks
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
/api/versionto includeFixes #3415