feat: Groups menu overflow shadows#7702
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Jul 17, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7702 +/- ##
==========================================
- Coverage 88.98% 88.79% -0.20%
==========================================
Files 291 296 +5
Lines 40717 41319 +602
==========================================
+ Hits 36233 36688 +455
- Misses 4484 4631 +147 ☔ View full report in Codecov by Sentry. |
NGPixel
approved these changes
Jul 17, 2024
Member
|
There are a few other places where we have UI that has a scrollbar that could use this treatment - hopefully it generalizes and will be easy to apply in those spots (example, the various dropdowns on the search page). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #7528 this adds a
box-shadowto indicate that more scrolling is available. This is a common UX pattern, and it requires JavaScript.Here's how it looks,