Skip to content

feat: Groups menu overflow shadows#7702

Merged
rjsparks merged 1 commit intoietf-tools:mainfrom
holloway:feat/overflow-shadows
Jul 17, 2024
Merged

feat: Groups menu overflow shadows#7702
rjsparks merged 1 commit intoietf-tools:mainfrom
holloway:feat/overflow-shadows

Conversation

@holloway
Copy link
Copy Markdown
Contributor

To resolve #7528 this adds a box-shadow to indicate that more scrolling is available. This is a common UX pattern, and it requires JavaScript.

Here's how it looks,

  • Light mode: Screenshot from 2024-07-17 12-36-56
  • Dark mode: Screenshot from 2024-07-17 12-37-16

@holloway holloway requested review from NGPixel and rjsparks July 17, 2024 00:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (187c2c5) to head (b00dfd3).
Report is 327 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7702      +/-   ##
==========================================
- Coverage   88.98%   88.79%   -0.20%     
==========================================
  Files         291      296       +5     
  Lines       40717    41319     +602     
==========================================
+ Hits        36233    36688     +455     
- Misses       4484     4631     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holloway holloway marked this pull request as ready for review July 17, 2024 20:14
@rjsparks rjsparks merged commit 6c74980 into ietf-tools:main Jul 17, 2024
@rjsparks
Copy link
Copy Markdown
Member

There are a few other places where we have UI that has a scrollbar that could use this treatment - hopefully it generalizes and will be easy to apply in those spots (example, the various dropdowns on the search page).

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menus mistakenly look complete when actually further content can be scrolled to

3 participants