refactor: don't use filesystem for draft aliases#7555
Merged
rjsparks merged 9 commits intoietf-tools:mainfrom Jun 18, 2024
Merged
refactor: don't use filesystem for draft aliases#7555rjsparks merged 9 commits intoietf-tools:mainfrom
rjsparks merged 9 commits intoietf-tools:mainfrom
Conversation
n.b., very slow for full set of aliases
The name != "" case is, as far as I can see, unused.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7555 +/- ##
==========================================
- Coverage 88.98% 88.95% -0.04%
==========================================
Files 291 295 +4
Lines 40717 41231 +514
==========================================
+ Hits 36233 36675 +442
- Misses 4484 4556 +72 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the need for a copy of the postfix draft aliases file in reach of the datatracker. The full listing of draft aliases is quite slow this way - please check in particular that I'm using the slowpages cache correctly.