chore: adjustments for k8s deployment - #7531
Merged
Merged
Conversation
Used by the infra-k8s deployment process to flag these as needing to be shut down before a new release rolls out.
rjsparks
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big change here is to
celery-start.sh, which now waits until all migrations have been applied before starting the celery container. This will prevent celery from running against an incompatible database.Also arranges for gunicorn to receive a TERM signal when Docker politely asks the datatracker pod to shut down. Without this, stopping the pod lingers until the grace period expires.