feat: use surname/initials for author name#7510
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Jun 6, 2024
Merged
Conversation
Collaborator
|
Looks good to me. |
rjsparks
reviewed
Jun 6, 2024
Member
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
One question inline before approving
Comment on lines
13
to
+14
| {% for author in submission.authors %} | ||
| <button type="button" | ||
| class="author btn btn-primary mb-3" | ||
| data-name="{{ author.name }}" | ||
| data-email="{% if author.email %}{{ author.email }}{% endif %}"> | ||
| {{ author.name }} | ||
| </button> | ||
| {% if author.name %} |
Member
There was a problem hiding this comment.
if author.name is None for all authors in submission.authors, does the form fail?
Member
Author
There was a problem hiding this comment.
No, these buttons are just present to quick-fill the actual form field via javascript. If there are no buttons, then the submitter has to fill in the fields manually.
rjsparks
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds logic similar to what is used in xml2rfc's
TextWriterto render an author name from theinitialsand/orsurnamefields whenfullnameis not present.I've also updated places where we display the name to account for the possibility that the name is absent. If possible, I show the affiliation instead. This again matches what
TextWriterdoes when rendering an RFC.@russhousley