Skip to content

fix: Scroll metadata sidebar tab content#7499

Merged
rjsparks merged 2 commits intoietf-tools:mainfrom
holloway:metadata-sidebar-7390
Jun 6, 2024
Merged

fix: Scroll metadata sidebar tab content#7499
rjsparks merged 2 commits intoietf-tools:mainfrom
holloway:metadata-sidebar-7390

Conversation

@holloway
Copy link
Copy Markdown
Contributor

@holloway holloway commented Jun 3, 2024

An attempt at addressing #7390 which looks like,

Chrome
Screenshot from 2024-06-05 14-24-13

Firefox
Screenshot from 2024-06-05 14-24-50

For UX reasons just the tab content in the sidebar has been made scrollable. Is that ok? The UX reason are that if the sidebar had a full scrollbar it would look like the page itself had 2 scrollbars, whereas this is more clearly just making the tab content scrollable. This does mean that very short screens might not have enough visible scrolling area but such a small screen is probably mobile/tablet which needs a different responsive approach anyway.

Thoughts?

@larseggert @martinthomson

@holloway holloway requested a review from larseggert June 3, 2024 23:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (187c2c5) to head (e3cba5e).
Report is 229 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7499      +/-   ##
==========================================
- Coverage   88.98%   88.92%   -0.07%     
==========================================
  Files         291      295       +4     
  Lines       40717    41224     +507     
==========================================
+ Hits        36233    36658     +425     
- Misses       4484     4566      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holloway
Copy link
Copy Markdown
Contributor Author

holloway commented Jun 5, 2024

About #e3cba5e ...some browsers/platforms don't allocate space for scrollbars (ie they have zero-width scrollbars that only float above the page) which means two scrollbars could render ontop of each other. This adds some additional spacing.

@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Jun 6, 2024

This looks good to me - Martin and Lars have had time to comment. I'll merge this in and it will be part of the next release (which might be tomorrow).

@rjsparks rjsparks merged commit 3e09c14 into ietf-tools:main Jun 6, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants