fix: exception if submission files missing#7458
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom May 24, 2024
Merged
Conversation
This allows an exception to be raised if submission files are missing, leading to a server error. That's not pretty, but is better than ignoring the fail.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7458 +/- ##
==========================================
- Coverage 88.98% 88.93% -0.06%
==========================================
Files 291 294 +3
Lines 40717 41175 +458
==========================================
+ Hits 36233 36618 +385
- Misses 4484 4557 +73 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an exception to be raised if submission files are missing, leading to a server error. That's not pretty, but is better than ignoring the fail.