fix: validate form in login()#7435
Merged
rjsparks merged 6 commits intoietf-tools:mainfrom May 24, 2024
Merged
Conversation
Preserves old behavior, but avoids some hacks.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7435 +/- ##
==========================================
- Coverage 88.98% 88.91% -0.08%
==========================================
Files 291 294 +3
Lines 40717 41181 +464
==========================================
+ Hits 36233 36617 +384
- Misses 4484 4564 +80 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents 500s if username/password contain null characters. It refactors our custom
login()view as a customLoginViewsubclass and an associated customAuthenticationFormsubclass.The following applied to the first commit only (which broke the ability to log in using any email address):
The error is happening in some checks we do prior to the actual authentication check - it's looking to see if the User's password was cleared and whether it has a Person. The actual auth happens in theLoginView.as_view()call, which already checks and rejects attempts involving null characters. If that were to change, this PR would potentially make it possible someone to bypass the checks for a cleared password or missing Person. I don't think that's either likely or harmful, but wanted to point at it.