refactor: generate I-D bibxml files via celery#7426
Merged
rjsparks merged 5 commits intoietf-tools:mainfrom May 16, 2024
Merged
refactor: generate I-D bibxml files via celery#7426rjsparks merged 5 commits intoietf-tools:mainfrom
rjsparks merged 5 commits intoietf-tools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7426 +/- ##
==========================================
- Coverage 88.98% 88.93% -0.06%
==========================================
Files 291 293 +2
Lines 40717 41122 +405
==========================================
+ Hits 36233 36570 +337
- Misses 4484 4552 +68 ☔ View full report in Codecov by Sentry. |
Member
|
What testing there is is through the view that uses the function. The test of that view is here: Line 2085 in de8b3b5 |
rjsparks
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell we don't actually test the
bibxml_for_draft()method. I've added tests of the plumbing in the new task and its utility methods but testing the bibxml generation is beyond the scope of this PR...