Merged
Conversation
This is not used (there _is_ a setting for the django.security logger in settings_local.py on production, but it is redundant with the settings.LOGGING configuration and is not doing anything).
rjsparks
previously approved these changes
May 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7419 +/- ##
==========================================
- Coverage 88.98% 88.89% -0.09%
==========================================
Files 291 291
Lines 40717 41044 +327
==========================================
+ Hits 36233 36488 +255
- Misses 4484 4556 +72 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the logging changes made on feat/helm and feat/k8s and adjusts the log setup to be compatible with current production.
Strips out the
UTILS_LOGGER_LEVELmechanism that we're not currently using (explanation in the commit description).Rather than bringing back the direct calls to
syslog.syslogin theietf.utils.logmodule, this keeps @rjsparks's change directing those logs to thedatatrackerlogger. That logger is configured to go to syslog via theSysLogHandler.A change on the k8s
settings_local.pywe deploy will be needed to do this:which should preserve its current configuration.