feat: get tool versions without VersionInfo model#7418
feat: get tool versions without VersionInfo model#7418rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
* chore: remove update_external_command_info call * feat: get tool version without VersionInfo * chore: Remove VersionInfo model * chore: Migration to remove VersionInfo * fix: handle errors better; ignore stderr
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7418 +/- ##
==========================================
- Coverage 88.98% 88.84% -0.15%
==========================================
Files 291 292 +1
Lines 40717 41068 +351
==========================================
+ Hits 36233 36486 +253
- Misses 4484 4582 +98 ☔ View full report in Codecov by Sentry. |
| return "Unknown" | ||
| elif item not in self._versions: | ||
| try: | ||
| self._versions[item] = subprocess.run( |
There was a problem hiding this comment.
One thought that occurs to me is that this puts the time to invoke these 4 things (which should be fast) in the warmup path of every worker thread.
I'm willing to give this a shot, but if we're not already planning to do so in feat/k8s, maybe this should be replaced with something that happens at build time?
There was a problem hiding this comment.
Yes, moving to a build time mechanism would be better. I expect that since we generally (or maybe always) actually do work with the tool we ask for the version of, any overhead will be really small by comparison. I guess that's not guaranteed though.
This has the virtue of working both on ietfa and in a container, so it'll bridge the move to the new infrastructure.
2 participants
chore: remove update_external_command_info call
feat: get tool version without VersionInfo
chore: Remove VersionInfo model
chore: Migration to remove VersionInfo
fix: handle errors better; ignore stderr