feat: get tool versions without VersionInfo model#7393
Merged
jennifer-richards merged 5 commits intoietf-tools:feat/helmfrom May 4, 2024
Merged
feat: get tool versions without VersionInfo model#7393jennifer-richards merged 5 commits intoietf-tools:feat/helmfrom
jennifer-richards merged 5 commits intoietf-tools:feat/helmfrom
Conversation
rjsparks
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7392
Checks version at run-time. We could be clever about providing versions at docker-build-time if we want to accelerate this, but the checks are not expensive.
The original code combined stdout and stderr, I presume in case a tool returned its version via stderr. All of the tools we currently use write their version to stdout so this ignores stderr.