Skip to content

fix: Exclude replaced documents from IESG discusses#7258

Closed
pselkirk wants to merge 1 commit into
ietf-tools:mainfrom
pselkirk:fix-7179
Closed

fix: Exclude replaced documents from IESG discusses#7258
pselkirk wants to merge 1 commit into
ietf-tools:mainfrom
pselkirk:fix-7179

Conversation

@pselkirk

Copy link
Copy Markdown
Contributor

Fixes #7179

@codecov

codecov Bot commented Mar 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (187c2c5) to head (421994f).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7258      +/-   ##
==========================================
- Coverage   88.98%   88.84%   -0.15%     
==========================================
  Files         291      291              
  Lines       40717    41102     +385     
==========================================
+ Hits        36233    36516     +283     
- Misses       4484     4586     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good (though it could be simplified to chain the exclude onto the existing statement, and the whole statement could benefit from being processed by black.)

But there should be a test that proves it. I suspect it will be a small adjustment to an existing test.

@rjsparks

Copy link
Copy Markdown
Member

OBE by #7712

@rjsparks rjsparks closed this Jul 20, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replaced documents show on https://datatracker.ietf.org/iesg/discusses/ - they shouldn't.

2 participants