fix: Exclude replaced documents from IESG discusses#7258
Closed
pselkirk wants to merge 1 commit into
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7258 +/- ##
==========================================
- Coverage 88.98% 88.84% -0.15%
==========================================
Files 291 291
Lines 40717 41102 +385
==========================================
+ Hits 36233 36516 +283
- Misses 4484 4586 +102 ☔ View full report in Codecov by Sentry. |
rjsparks
requested changes
Mar 26, 2024
rjsparks
left a comment
Member
There was a problem hiding this comment.
This is good (though it could be simplified to chain the exclude onto the existing statement, and the whole statement could benefit from being processed by black.)
But there should be a test that proves it. I suspect it will be a small adjustment to an existing test.
This was referenced Jul 20, 2024
Closed
Member
|
OBE by #7712 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7179