ci: parameterize / update settings#7248
Merged
rjsparks merged 19 commits intoietf-tools:feat/helmfrom Mar 27, 2024
Merged
Conversation
NGPixel
approved these changes
Mar 22, 2024
richsalz
reviewed
Mar 22, 2024
(it's a symlink on production)
Member
Author
|
I believe this is ready for review - I have also adopted the changes suggested in #7250 (but check whether I missed anything because I did it manually) |
Member
Author
|
Also, note in particular 8537e48. I think we want to do this (and I think it'll work without issue on ietfa while making things slightly easier on the new infrastructure) Additionally 7132fcb, 882993e, and 586093c remove some unused things from |
rjsparks
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating as a draft because this is still a WIP.Inhelm/settings_local.py, I've made a stab at pulling settings out to the environment. Major question is whether this is the right balance.Notably not resolved is how the API keys dict gets populated - it's currently filled in with "redacted" values.