ci: give rabbitmq a persistent volume claim#7235
Merged
rjsparks merged 3 commits intoietf-tools:feat/helmfrom Mar 19, 2024
Merged
ci: give rabbitmq a persistent volume claim#7235rjsparks merged 3 commits intoietf-tools:feat/helmfrom
rjsparks merged 3 commits intoietf-tools:feat/helmfrom
Conversation
This relies on minikube's dynamic creation of persistent volumes - expect changes likely needed for production deployment.
rjsparks
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a persistent volume claim for rabbitmq. As-is, it at least works with minikube, which creates a persistent volume on its VM to satisfy the claim. I expect this will need attention when moving to aws deployment, so this is something of a stub for now.
A couple bits of cleanup as well.