fix: add celery tasks for idnits2 and bibxml file generation#7204
fix: add celery tasks for idnits2 and bibxml file generation#7204rjsparks merged 7 commits intoietf-tools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7204 +/- ##
==========================================
- Coverage 88.98% 88.79% -0.20%
==========================================
Files 291 296 +5
Lines 40717 41312 +595
==========================================
+ Hits 36233 36682 +449
- Misses 4484 4630 +146 ☔ View full report in Codecov by Sentry. |
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
One typo, one small change I think we should make.
| write_bibxml_file_if_changed(ref_rev_file_name, bibxml) | ||
| except Exception as ee: | ||
| log.log('\n%s-%s: %s\n' % (e.doc.name, e.doc.rev, str(ee))) | ||
| raise ee |
There was a problem hiding this comment.
Here and in bibxml_for_recent_drafts(), the re-raise of the exception is a change from the management command. In those, the exception was written to stderr and the script continued. The change means that the task will stop after an error.
I think we want to keep the old behavior (i.e., remove the raise ee here and on line 1299). I hope this doesn't contradict something we discussed at the code sprint. @russhousley do you recall?
There was a problem hiding this comment.
Sounds fine to me.
| content = f.read() | ||
| self.assertIn(draft.title, content) | ||
|
|
||
| def test_generate_bibxml_files_for_recent_drafts_task_with_bad_vakue(self): |
There was a problem hiding this comment.
Goof catch. I read past it many times.
Fix typo: bad_vakue -> bad_value
Don't raise error inbibxml_for_all_drafts
NGPixel
changed the title
# Conflicts: # ietf/doc/tasks.py # ietf/doc/tests_tasks.py
|
In the scramble to cut over to the new infrastructure, I lost track of this PR and wound up reimplementing it slightly differently. I'm merging that over so we can merge this. |
3 participants
Add celery tasks for idnits2 and bibxml file generation. Fixes #7192