Skip to content

fix: Missing button text for PostScript#7200

Merged
rjsparks merged 8 commits intoietf-tools:mainfrom
evyncke:fix-6900
Mar 20, 2024
Merged

fix: Missing button text for PostScript#7200
rjsparks merged 8 commits intoietf-tools:mainfrom
evyncke:fix-6900

Conversation

@evyncke
Copy link
Copy Markdown
Collaborator

@evyncke evyncke commented Mar 16, 2024

This fixes #6900 by avoiding any Postscript file in the list of built URL for a document,

@evyncke evyncke mentioned this pull request Mar 16, 2024
1 task
Comment thread ietf/doc/utils.py Outdated
@evyncke
Copy link
Copy Markdown
Collaborator Author

evyncke commented Mar 16, 2024

Note: I was unable to fully test it as my docker environment does not have the full archived drafts, but add empty draft-ietf-tsvwg-quickstart-07.ps/txt/pdf locally and it works (i.e., txt/pdf buttons are displayed and nothing for ps)

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.94%. Comparing base (187c2c5) to head (b31e446).
Report is 64 commits behind head on main.

❗ Current head b31e446 differs from pull request most recent head 4478125. Consider uploading reports for the commit 4478125 to get more accurate results

Files Patch % Lines
ietf/doc/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
- Coverage   88.98%   88.94%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41069     +352     
==========================================
+ Hits        36233    36528     +295     
- Misses       4484     4541      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit faa3efd into ietf-tools:main Mar 20, 2024
@evyncke evyncke deleted the fix-6900 branch March 21, 2024 06:55
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing button text for PostScript

3 participants