fix: Add history line when changing the review deadline. (fixes #6598)#7194
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Mar 21, 2024
Merged
fix: Add history line when changing the review deadline. (fixes #6598)#7194rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
rjsparks
reviewed
Mar 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
- Coverage 88.98% 88.94% -0.05%
==========================================
Files 291 291
Lines 40717 41067 +350
==========================================
+ Hits 36233 36526 +293
- Misses 4484 4541 +57 ☔ View full report in Codecov by Sentry. |
jennifer-richards
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add history line when the review deadline is changed. Also fixes the subject line of the email sent out, so if there is no specific revision requested it does not print the extra "-" at the end.
Subject used to look:
Subject: Deadline changed: Secdir last call review of draft-ietf-opsawg-9092-update-
now it will look:
Subject: Deadline changed: Secdir last call review of draft-ietf-opsawg-9092-update