feat: More clarity in nomcom feedback, and ...#7191
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Mar 16, 2024
Merged
feat: More clarity in nomcom feedback, and ...#7191rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
For consistency, in email and photo tooltips, remove the trailing period.
Seeing "User Name {envelope}" seems to confuse people; it's two links,
not one. So don't show the envelope-icon,
Also change text to say "current nomcom" when saying who gets it.
Fixes: ietf-tools#7032
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7191 +/- ##
==========================================
- Coverage 88.98% 88.94% -0.05%
==========================================
Files 291 291
Lines 40717 41063 +346
==========================================
+ Hits 36233 36522 +289
- Misses 4484 4541 +57 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be consistent in photo and email tooltips.