feat: Only send slides notifications near session time#7170
Merged
jennifer-richards merged 2 commits intoietf-tools:feat/sess-apisfrom Mar 12, 2024
Merged
feat: Only send slides notifications near session time#7170jennifer-richards merged 2 commits intoietf-tools:feat/sess-apisfrom
jennifer-richards merged 2 commits intoietf-tools:feat/sess-apisfrom
Conversation
Don't let errors in the MeetEcho slides API interfere with the ability to modify slides for a session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change here is to limit the sessions for which slides updates result in calls to the MeetEcho API. This adds a
slides_notify_timeoption to theMEETECHO_API_CONFIGdict to control the window around the session during which notifications will be sent. This is a number of minutes (defaults to 15) before / after the session where changes will be pushed to MeetEcho. If it is set toNone, then updates are disabled entirely, and if it is< 0then the window is infinite (for debugging). Regardless, the API will be called only for scheduled sessions.As a general improvement, also catches exceptions from the slide update calls - this will prevent errors in the MeetEcho update from breaking slide updates entirely.