feat: add Meetecho to upload/remove slides; refactor upload_session_slides#7146
Merged
jennifer-richards merged 7 commits intoietf-tools:feat/sess-apisfrom Mar 6, 2024
Merged
Conversation
Avoids double-save of a SessionPresentation for the session being updated and updates other sessions when apply_to_all is set (previously it only created ones that did not exist, so rev would never be updated).
rjsparks
approved these changes
Mar 6, 2024
Removed some type checking rather than debugging it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next slew of updates to use Meetecho's API to improve slide management. The main work here is to make API calls when uploading or removing slides using the buttons on the session materials page.
A moderately substantial refactor of
upload_session_slides()is included here. This change eliminates a double-save of aSessionPresentationwhen replacing a slide deck with a new revision. It also updates theSessionPresentationinstances for all sessions when theapply_to_alloption is enabled - the original implementation created missing ones but did not update ones that already existed (except for the one related tosessionitself). That introduced skew betweenrevfor the session used to upload the new rev and all the other sessions.