fix: Do not force showAgenda when agenda_note is set#7142
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Mar 5, 2024
Merged
fix: Do not force showAgenda when agenda_note is set#7142rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7142 +/- ##
==========================================
- Coverage 88.98% 88.97% -0.01%
==========================================
Files 291 291
Lines 40717 40839 +122
==========================================
+ Hits 36233 36338 +105
- Misses 4484 4501 +17 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where "break" and "other" type sessions with
agenda_noteare shown with notepad and other irrelevant links.At least for IETF-119's' schedule, I don't see any sessions that unexpectedly lose these links as a result of this change