refactor: Clarify which mail archive is being searched#7117
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Mar 11, 2024
Merged
refactor: Clarify which mail archive is being searched#7117rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
rjsparks
requested changes
Feb 29, 2024
Member
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
I'm not following part of the suggested change:
|
|
||
| mail_archive_query_urls = mailarch.construct_query_urls(doc, team) | ||
|
|
||
| team_list_email = team.list_email or "directorate" |
Member
There was a problem hiding this comment.
This conditional isn't making sense to me. Isn't it the case that if team.list_email is not Truthy, that mail_archive_query_urls will be None? (see the first return in `construct_query_urls).
I also don't think you need this extra variable - if mail_archive_query_urls exists, see if you can get what need out of it in the template?
rjsparks
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6993