fix: Revert "Email authors" link for an RFC to the draft that it came from#7077
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Feb 28, 2024
Merged
fix: Revert "Email authors" link for an RFC to the draft that it came from#7077rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
rjsparks
requested changes
Feb 26, 2024
Member
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
The tests aren't looking at the link generated for the button. Maybe they should - if we left the changes to document_draft.html in place, the button would have generated a bad URL I think.
Comment on lines
+614
to
+616
| href="mailto:{{ doc_name }}@ietf.org?subject=Mail%20regarding%20{{ doc.name }}"> | ||
| <i class="bi bi-envelope"> | ||
| </i> |
Member
There was a problem hiding this comment.
This should be a full revert - there should be no changes to document_draft.html for this PR.
rjsparks
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6856