feat: Add Announcements link to nomcom home page - #7053
Merged
Conversation
rjsparks
requested changes
Feb 13, 2024
| {% origin %} | ||
| <!-- [html-validate-disable-block heading-level -- FIXME: old HTML in the database] --> | ||
| {{ template|safe }} | ||
| {% if nomcom.ann_url %} |
Member
There was a problem hiding this comment.
This should probably come before rendering the template, and it probably needs more dressing.
"Announcements from this nomcom are available <here>"
or something like it.
Maybe we need a block in the base template for it instead of intruding on the nomcom_content block.
rjsparks
requested changes
Feb 26, 2024
rjsparks
left a comment
rjsparks
left a comment
Member
There was a problem hiding this comment.
Avoid coding URL paths into templates - use the {% url %} templetag instead.
| {% block nomcom_announce %} | ||
| <p class="alert alert-info my-3"> | ||
| Announcements from this nomcom are available | ||
| <a href="/nomcom/ann/#nomcom-{{year}}">here</a> |
Member
There was a problem hiding this comment.
Suggested change
| <a href="/nomcom/ann/#nomcom-{{year}}">here</a> | |
| <a href="{% url "ietf.nomcom.views.announcements" %}#nomcom-{{year}}">here</a> |
rjsparks
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6886