feat: Group admin form accepts acronyms starting with numbers for SDO groups#7051
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Feb 20, 2024
Merged
feat: Group admin form accepts acronyms starting with numbers for SDO groups#7051rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7051 +/- ##
==========================================
+ Coverage 88.91% 88.97% +0.05%
==========================================
Files 289 291 +2
Lines 40454 40717 +263
==========================================
+ Hits 35971 36226 +255
- Misses 4483 4491 +8 ☔ View full report in Codecov by Sentry. |
rjsparks
requested changes
Feb 12, 2024
Member
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
Need to tune/test the sdo acronym validation a bit more.
rjsparks
reviewed
Feb 12, 2024
rjsparks
requested changes
Feb 12, 2024
Member
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
Please add the fail tests for group type wg for leading or trailing hyphens
rjsparks
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6825