refactor: use statics.ietf.org for all statics#6936
refactor: use statics.ietf.org for all statics#6936rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
jennifer-richards
left a comment
There was a problem hiding this comment.
This looks good to me. Assuming you'll be collecting static files in an environment where the STATIC_ROOT is not None it should be ok. (I don't think it's necessary to clear it out, but it's a nice hint and I don't see that it will cause any problems.)
|
@NGPixel - does the build environment already override STATIC_ROOT? |
You mean dev? I don't see it being overridden in https://github.com/ietf-tools/datatracker/blob/main/docker/configs/settings_local.py |
|
No - I meant build - as in "create a production release" - in what context are you running |
|
Answer is at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6936 +/- ##
==========================================
- Coverage 88.80% 88.80% -0.01%
==========================================
Files 285 285
Lines 40383 40383
==========================================
- Hits 35863 35862 -1
- Misses 4520 4521 +1 ☔ View full report in Codecov by Sentry. |
No description provided.