Skip to content

refactor: use statics.ietf.org for all statics#6936

Merged
rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks:static_statics
Jan 19, 2024
Merged

refactor: use statics.ietf.org for all statics#6936
rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks:static_statics

Conversation

@rjsparks
Copy link
Copy Markdown
Member

No description provided.

Comment thread ietf/settings.py Outdated
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Assuming you'll be collecting static files in an environment where the STATIC_ROOT is not None it should be ok. (I don't think it's necessary to clear it out, but it's a nice hint and I don't see that it will cause any problems.)

@rjsparks rjsparks requested a review from NGPixel January 19, 2024 20:07
@rjsparks
Copy link
Copy Markdown
Member Author

@NGPixel - does the build environment already override STATIC_ROOT?

@NGPixel
Copy link
Copy Markdown
Member

NGPixel commented Jan 19, 2024

@NGPixel - does the build environment already override STATIC_ROOT?

You mean dev? I don't see it being overridden in https://github.com/ietf-tools/datatracker/blob/main/docker/configs/settings_local.py

@rjsparks
Copy link
Copy Markdown
Member Author

No - I meant build - as in "create a production release" - in what context are you running collectstatic to gather the statics to put at R2?

@rjsparks
Copy link
Copy Markdown
Member Author

Answer is at

STATIC_ROOT = os.path.abspath(BASE_DIR + "/../static/")

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06f496c) 88.80% compared to head (b38e8c3) 88.80%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6936      +/-   ##
==========================================
- Coverage   88.80%   88.80%   -0.01%     
==========================================
  Files         285      285              
  Lines       40383    40383              
==========================================
- Hits        35863    35862       -1     
- Misses       4520     4521       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 6da9dff into ietf-tools:main Jan 19, 2024
@rjsparks rjsparks deleted the static_statics branch January 19, 2024 20:57
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants