fix: Never show AD col on drafts_for_ad.html#6914
Merged
rjsparks merged 4 commits intoietf-tools:mainfrom Jan 12, 2024
Merged
Conversation
Results being shown are already filtered by AD if the `ad` variable is not `None`
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6914 +/- ##
==========================================
- Coverage 88.80% 88.80% -0.01%
==========================================
Files 284 285 +1
Lines 40361 40377 +16
==========================================
+ Hits 35843 35857 +14
- Misses 4518 4520 +2 ☔ View full report in Codecov by Sentry. |
rjsparks
previously approved these changes
Jan 12, 2024
rjsparks
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix a transient HTML validation failure caused by assuming
ad.name != doc.ad.plain_name()indicated thatad != doc.ad.That check was, as far as I can tell, unnecessary because the search results were selected using
doc.ad == ad. The check is removed here.I'm leaving in the initial change from including
ad_nametoadin the template context because I don't see a benefit to handing around the string instead of the full record.For the record, the transient failure was: