Skip to content

feat: Import IESG artifacts into the datatracker#6908

Merged
rjsparks merged 35 commits intomainfrom
feat/iesgart
Feb 20, 2024
Merged

feat: Import IESG artifacts into the datatracker#6908
rjsparks merged 35 commits intomainfrom
feat/iesgart

Conversation

@rjsparks
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (187c2c5) 88.98% compared to head (0572e68) 88.97%.
Report is 17 commits behind head on main.

❗ Current head 0572e68 differs from pull request most recent head 2bf1bae. Consider uploading reports for the commit 2bf1bae to get more accurate results

Files Patch % Lines
ietf/meeting/models.py 70.00% 6 Missing ⚠️
ietf/group/views.py 91.17% 3 Missing ⚠️
ietf/doc/models.py 75.00% 1 Missing ⚠️
ietf/doc/views_material.py 50.00% 1 Missing ⚠️
ietf/meeting/templatetags/proceedings_filters.py 0.00% 1 Missing ⚠️
ietf/meeting/utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6908      +/-   ##
==========================================
- Coverage   88.98%   88.97%   -0.02%     
==========================================
  Files         291      291              
  Lines       40717    40766      +49     
==========================================
+ Hits        36233    36270      +37     
- Misses       4484     4496      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only partially reviewed, but I think the tz handling is fragile and should probably be fixed. I expect that the dev machines will show incorrect times on migrated data. (If not, then I must be mistaken in my comments.)

Comment thread ietf/doc/views_doc.py Outdated
Comment thread ietf/group/management/commands/import_iesg_appeals.py Outdated
Comment thread ietf/meeting/management/commands/import_iesg_minutes.py
Comment thread ietf/meeting/management/commands/import_iesg_minutes.py Outdated
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - I think the tz stuff is still in need of changes.

The n+1 business looks good to me, but I'm still thinking about how it can be made more maintainable.

Comment thread ietf/group/views.py Outdated
Comment thread ietf/meeting/models.py
Comment thread ietf/meeting/management/commands/import_iesg_minutes.py Outdated
Comment thread ietf/meeting/management/commands/import_iesg_minutes.py Outdated
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns are addressed.

I'm a little uneasy about the monkey patched optimizations - it'd be nice to find a better pattern for that. I don't see a reason to hold this up for solving that, though.

Comment thread ietf/group/management/commands/import_iesg_appeals.py
@rjsparks rjsparks marked this pull request as draft January 19, 2024 21:31
@rjsparks rjsparks marked this pull request as ready for review February 20, 2024 17:21
@rjsparks rjsparks merged commit 8cb7f3d into main Feb 20, 2024
@jennifer-richards jennifer-richards deleted the feat/iesgart branch February 23, 2024 19:24
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants