fix: Properly set AD as action holder when submitting to IESG for publication - #6854
Merged
Conversation
…lication (ietf-tools#5227) The clear intent of `to_iesg` is that a) the document AD should be the group AD, if not already set, and b) the document Action Holder should be the document AD; but there was an order-of-operation error, such that the Action Holder remained empty.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6854 +/- ##
==========================================
+ Coverage 88.78% 88.79% +0.01%
==========================================
Files 285 285
Lines 40324 40374 +50
==========================================
+ Hits 35800 35852 +52
+ Misses 4524 4522 -2 ☔ View full report in Codecov by Sentry. |
…ues into the parent scope
rjsparks
requested changes
Jan 2, 2024
Comment on lines
+567
to
+569
| e = DocEvent(type=type, by=by, doc=doc, rev=doc.rev, desc=desc) | ||
| e.save() | ||
| return e |
Member
There was a problem hiding this comment.
Suggested change
| e = DocEvent(type=type, by=by, doc=doc, rev=doc.rev, desc=desc) | |
| e.save() | |
| return e | |
| return DocEvent.objects.create(type=type, by=by, doc=doc, rev=doc.rev, desc=desc) |
Member
There was a problem hiding this comment.
Or
return doc.docevent_set.create(type=type, by=by, rev=doc.rev, desc=desc)
rjsparks
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5227
The clear intent of
to_iesgis thata) the document AD should be the group AD, if not already set, and b) the document Action Holder should be the document AD; but there was an order-of-operation error,
such that the Action Holder remained empty.