fix: sorting RFCs by date in personal profiles sorts#6851
fix: sorting RFCs by date in personal profiles sorts#6851aj-stein-nist wants to merge 0 commit intoietf-tools:mainfrom
Conversation
aj-stein-nist
changed the title
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
Thank you for the PR!
As noted inline, I think you should take a slightly different approach.
| <a class="text-nowrap" href="{{ doc.get_absolute_url }}">RFC {{ doc.rfc_number }}</a> | ||
| </td> | ||
| <td>{{ doc.pub_date|date:"b Y"|title }}</td> | ||
| <td>{{ doc.pub_date|date:"Y-m-d"|title }}</td> |
There was a problem hiding this comment.
If you look at the first page of RFCs, they only show Month and Year for when they were published, except for Apr 1 RFCs which show the date. We do have a published date in the database, but the RFC Editor wants this page to reflect what the RFC editor website would show.
Rather than this particular fix, we may want to add a separate undisplayed sort key (I think we have this in other sortable tables) for the column.
There was a problem hiding this comment.
@larseggert Can you point to an example where we've provided an alternate sort function or sort values?
There was a problem hiding this comment.
Sounds good. I will research this and try to get back at it on Friday. So just to be clear, if I switch to the approach (thanks so much for the context, I suspected my fix was too easy if you labelled it "medium" difficulty 😆), do I need frontend tests or does that not cover the Django server-side generated content? Just want to make my PR easy to review and meet your standards. I am a first-timer on ietf-tools.
Thanks again for the quick reply!
There was a problem hiding this comment.
Very happy to have you start in on contributing!
Our front-end test framework for older views is not well, and will be replaced.. Please don't spend time trying to figure what's there out. Thanks for considering tests, but for this one we will use human visual inspection.
Several people that could help on this one are on holiday breaks, and we might not get feedback from them until next week.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
aj-stein-nist
force-pushed
the
5566-profile-template-adjust-dt-fix-date-sort
branch
from
341d71d to
c96a4f8
Compare
aj-stein-nist
force-pushed
the
5566-profile-template-adjust-dt-fix-date-sort
branch
from
c96a4f8 to
452d5da
Compare
3 participants
No description provided.