fix: Fix disclaimer logic#6797
Merged
rjsparks merged 1 commit intoietf-tools:feat/clarityfrom Dec 18, 2023
Merged
Conversation
Member
|
We really need a test (or more) that verifies this logic. If some well-meaning seemingly unrelated change breaks this and the wrong disclaimer starts showing on a subsequent release, the damage would be significant. |
Member
|
I'll merge this so we can see the result in the staging dev area, but I don't think we should merge the branch to main without a solid set of tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Slack