feat: Allow entering agenda text directly

[pselkirk]

Fixes #6532

[pselkirk]

For whatever reason (because I don't know javascript), the script that shows the appropriate file/text input box (taken from complete-review.js) doesn't hide the label of the hidden field.

[jennifer-richards]

For whatever reason (because I don't know javascript), the script that shows the appropriate file/text input box (taken from complete-review.js) doesn't hide the label of the hidden field.

The issue is that the bootstrap_form call is rendering the fields like (paraphrasing)

<div class="mb-3">
  <label class="form-label" ...>Agenda text</label>
  <textarea id="id_content" name="content" ...></textarea>
</div>

and you are selecting for [name="content"], which selects only the <textarea/>.

Easiest thing to do is to change line 54 of the template to var row = form.find(selector).parent(); so you hide the whole <div>...</div> wrapper. It's somewhat fragile, but I don't see a way to more directly label and select the wrapper <div/>.

Also, not sure if you're ready for review, but the JS code should go in its own module like is done for complete-review.js so that it can be packaged properly.

[pselkirk]

var row = form.find(selector).parent();

Thanks, that was the nudge I needed.

the JS code should go in its own module like is done for complete-review.js so that it can be packaged properly.

Yeah, I just wanted to get the JS working before going through the packaging step.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3a574c) 88.78% compared to head (4ecbf3e) 88.80%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6792      +/-   ##
==========================================
+ Coverage   88.78%   88.80%   +0.01%     
==========================================
  Files         285      285              
  Lines       40324    40367      +43     
==========================================
+ Hits        35800    35846      +46     
+ Misses       4524     4521       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jennifer-richards]

Suggestion inline - I'm open to discussion if you think it's preferable to stick with the status code checks as they are