fix: Include refs to pre-RFC drafts as refs to the RFC#6784
Merged
rjsparks merged 10 commits intoietf-tools:mainfrom Dec 18, 2023
Merged
fix: Include refs to pre-RFC drafts as refs to the RFC#6784rjsparks merged 10 commits intoietf-tools:mainfrom
rjsparks merged 10 commits intoietf-tools:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6784 +/- ##
==========================================
- Coverage 88.81% 88.78% -0.04%
==========================================
Files 285 285
Lines 40291 40324 +33
==========================================
+ Hits 35785 35800 +15
- Misses 4506 4524 +18 ☔ View full report in Codecov by Sentry. |
The test_referenced_by_rfcs_as_rfc_or_draft() test fails because there's a bug!
Let's do include refs to an rfc and its precursor draft as separate refs. This almost surely indicates a data error because it would mean an rfc referenced both an rfc and the draft that it came from. That should never be allowed, so at least let some light fall on it if it happens.
rjsparks
reviewed
Dec 15, 2023
rjsparks
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the person profile page, fixes ref counts to agree with what was showed pre-RFC model refactoring.
On the doc referencedBy page: