Skip to content

feat: Sort RFCs on subseries views; fix page title #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 4 commits into from
Nov 29, 2023
Merged

feat: Sort RFCs on subseries views; fix page title #6704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0e5450
feat: Sort RFCs on subseries doc pages
jennifer-richards Nov 29, 2023
8041c37
feat: Sort RFCs on subseries index pages
jennifer-richards Nov 29, 2023
35e96bc
fix: Show subseries doc name as page title
jennifer-richards Nov 29, 2023
9aedf09
refactor: Use prettystdname filter for consistency
jennifer-richards Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ietf/templates/doc/document_subseries.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
{# Copyright The IETF Trust 2023, All Rights Reserved #}
{% load origin %}
{% load static %}
{% block title %}{{doc.type.name}}s{% endblock %}
{% load ietf_filters %}
{% block title %}{{ doc.name|prettystdname }}{% endblock %}
{% block content %}
{% origin %}
{{ top|safe }}
<h2>{{ doc.name|slice:":3"|upper }} {{ doc.name|slice:"3:"}} {% if doc.contains %}consists of:{% else %}currently contains no RFCs{% endif %}</h2>
{% for rfc in doc.contains %}
<h2>{{ doc.name|prettystdname }} {% if doc.contains %}consists of:{% else %}currently contains no RFCs{% endif %}</h2>
{% for rfc in doc.contains|dictsort:"rfc_number" %}
<p><a href="{% url 'ietf.doc.views_doc.document_main' name=rfc.name %}">RFC {{rfc.name|slice:"3:"}}</a> : {{rfc.title}}</p>
{% endfor %}
<div class="buttonlist">
Expand All @@ -26,4 +27,4 @@ <h2>{{ doc.name|slice:":3"|upper }} {{ doc.name|slice:"3:"}} {% if doc.contains
Referenced by
</a>
</div>
{% endblock %}
{% endblock %}
2 changes: 1 addition & 1 deletion ietf/templates/doc/document_subseries_top.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% origin %}
{% load ietf_filters %}
<h1>
{{ doc.name|slice:":3"|upper }} {{ doc.name|slice:"3:"}}
{{ doc.name|prettystdname }}
</h1>
<ul class="nav nav-tabs my-3">
{% for name, t, url, active, tooltip in tabs %}
Expand Down
2 changes: 1 addition & 1 deletion ietf/templates/doc/index_subseries.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h1>{{type.name}}s</h1>
<div class="card mb-3" id="{{doc.name}}">
<div class="card-header"><a href="{% url 'ietf.doc.views_doc.document_main' name=doc.name %}">{{doc.name|prettystdname}}</a></div>
<div class="card-body">
{% for rfc in doc.contains %}
{% for rfc in doc.contains|dictsort:"rfc_number" %}
<p><a href="{% url 'ietf.doc.views_doc.document_main' name=rfc.name %}">{{rfc.name|prettystdname}}</a> : {{rfc.title}}</p>
{% empty %}
<p>{{doc.name|prettystdname}} currently contains no RFCs
Expand Down