fix: Combine Group and GroupHistory when counting#6701
Merged
rjsparks merged 5 commits intoietf-tools:mainfrom Nov 28, 2023
Merged
fix: Combine Group and GroupHistory when counting#6701rjsparks merged 5 commits intoietf-tools:mainfrom
rjsparks merged 5 commits intoietf-tools:mainfrom
Conversation
Member
Author
|
I'm assuming here that a group's acronym is not going to change - if that's not true, then a different fix will be needed |
Member
Author
|
Hmm. There are some exceptions - not sure if we need to worry about more. >>> pp([(a, b, c.isoformat()) for a, b, c in list(GroupHistory.objects.exclude(group__acronym=F("acronym")).values_list("acronym", "group__acronym", "time").order_by("-time").distinct())])
[('ETSI-ISG-QSC', 'etsi-isg-qsc', '2015-05-04T14:58:15+00:00'),
('ETSI-ISG-IP6', 'etsi-isg-ip6', '2015-05-01T15:38:18+00:00'),
('ITU-T-SG5', 'itu-t-sg-5', '2015-03-22T13:10:41+00:00'),
('itu-t-q3-16', 'itu-t-sg-16-q3', '2014-11-21T21:23:07+00:00'),
('WBA', 'wba', '2014-08-25T20:16:14+00:00'),
('itu-t-sg17-tsb', 'itu-t-sg-17-tsb', '2014-08-21T20:22:30+00:00'),
('itu-t-sg17-q4', 'itu-t-sg-17-q4', '2014-05-21T20:03:04+00:00'),
('dnssdext2', 'dnssdext', '2013-10-14T08:12:15+00:00'),
('dnssdext', 'dnssd', '2013-10-11T10:04:59+00:00'),
('dnssdx', 'dnssd', '2013-10-11T10:03:43+00:00'),
('dnssdext', 'dnssd', '2013-09-14T15:31:36+00:00'),
('dnssdext', 'dnssd', '2013-09-14T15:24:04+00:00'),
('dnssdext', 'dnssd', '2013-09-14T15:17:16+00:00'),
('ETSI-TC-EE', 'etsi-tc-ee', '2013-09-05T21:54:14+00:00'),
('3GPP-TSG-SA-WG4', '3gpp-tsgsa-sa4', '2013-07-18T16:07:12+00:00'),
('dnssdext', 'dnssd', '2013-06-20T18:05:13+00:00'),
('IEEE-802-OmniRAN', 'ieee-802-ec-omniran', '2013-03-01T16:59:08+00:00'),
('ieee-80211', 'ieee-802-11', '2012-08-28T20:26:59+00:00'),
('itu-t-fgd', 'itu-t-fg-dist', '2012-07-31T17:03:06+00:00'),
('IMTC', 'imtc', '2012-07-11T16:29:10+00:00'),
('ONF', 'onf', '2012-07-03T17:22:12+00:00'),
('dmmnew', 'dmm', '2012-03-05T17:38:10+00:00'),
('ieee-8021', 'ieee-802-1', '2012-02-26T08:21:37+00:00'),
('ieee-80223', 'ieee-802-23', '2012-02-26T08:21:37+00:00'),
('isoiec-jtc1-sc2', 'iso-iec-jtc1-sc2', '2012-02-26T08:21:37+00:00'),
('isoiec-jtc-1sc-29wg-11',
'iso-iec-jtc1-sc29-wg11',
'2012-02-26T08:21:37+00:00')]``` |
Member
Author
|
Ok - this should handle changes to the group acronym now. |
rjsparks
previously approved these changes
Nov 28, 2023
The filtering and meeting displays disagree on how to handle this, so let's get a notification if it comes up in production.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 285 285
Lines 40230 40224 -6
=======================================
- Hits 35734 35729 -5
+ Misses 4496 4495 -1 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6683