Fix: meeting important dates can have markdown links#6594
Conversation
| string = bleach_cleaner.clean( | ||
| python_markdown.markdown( | ||
| string, | ||
| extensions=[ | ||
| "extra", | ||
| "nl2br", | ||
| "sane_lists", | ||
| "toc", | ||
| ], | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Why don't you use/call the code in ietf/utils/markdown.py?
There was a problem hiding this comment.
Because of a loop between the import statement (and no clue how to break this loop)
There was a problem hiding this comment.
In the same vein, I am unsure whether "toc" & "nl2br" extensions are useful or dangerous
There was a problem hiding this comment.
|
I pushed a commit that moves the new filter to avoid the circular import (and simplifies it to use utils.markdown). Tests don't pass, but it's not this PRs fault. |
thanks, nicer indeed |
|
See the failed test run - the changes are producing html that doesn't validate. For example |
This was happening because the |
Indeed ! Thanks |
To address feat #3911
Added a filter for the Django templates: 'markdown'
Data migration includes changing the important dates description to include the right markdown links.
Still to do (another issue to be created?) as some links in important dates include the actual meeting number :-(