Skip to content

feat: Add disclaimer banners for unadopted I-Ds and non-IETF RFCs - #6589

Merged
rjsparks merged 7 commits into
ietf-tools:feat/clarityfrom
larseggert:fix-6539
Dec 15, 2023
Merged

feat: Add disclaimer banners for unadopted I-Ds and non-IETF RFCs#6589
rjsparks merged 7 commits into
ietf-tools:feat/clarityfrom
larseggert:fix-6539

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Fixes #6539

@codecov

codecov Bot commented Nov 4, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feat/clarity@f5bd078). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             feat/clarity    #6589   +/-   ##
===============================================
  Coverage                ?   88.78%           
===============================================
  Files                   ?      285           
  Lines                   ?    40332           
  Branches                ?        0           
===============================================
  Hits                    ?    35809           
  Misses                  ?     4523           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread ietf/templates/doc/disclaimer.html
@larseggert

Copy link
Copy Markdown
Collaborator Author

@elear indicated he is OK with this in email, so I guess we are good to go?

if not state:
return False

return True

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggling this value highlights that the PR is missing tests.

@rjsparks
rjsparks changed the base branch from main to feat/clarity December 15, 2023 15:47
@rjsparks
rjsparks merged commit 6a295da into ietf-tools:feat/clarity Dec 15, 2023
@larseggert
larseggert deleted the fix-6539 branch December 15, 2023 17:05
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 19, 2023
@ietf-tools ietf-tools unlocked this conversation Jan 8, 2024
@rdanyliw

rdanyliw commented Jan 8, 2024

Copy link
Copy Markdown

This text has been confirmed with all of the stream managers and the IESG. Ready to go.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disclaimer banner for unadopted I-Ds

4 participants