fix: Add history entry when approving the slides.#6588
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Nov 6, 2023
Merged
fix: Add history entry when approving the slides.#6588rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
Also changed os.rename to shutils.move as the submissions and proceedings are on the separate filesystems on the docker image, and this same thing might happen in the real environment in the future.
Contributor
Author
|
This fixes #5432 |
Codecov Report
@@ Coverage Diff @@
## main #6588 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 284 284
Lines 40253 40255 +2
=======================================
+ Hits 35765 35770 +5
+ Misses 4488 4485 -3
|
jennifer-richards
approved these changes
Nov 6, 2023
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
This looks ok to me, though should there also be an event for disapproval?
| if not os.path.exists(path): | ||
| os.makedirs(path) | ||
| os.rename(submission.staged_filepath(), os.path.join(path, target_filename)) | ||
| shutil.move(submission.staged_filepath(), os.path.join(path, target_filename)) |
Member
There was a problem hiding this comment.
Thank you for catching and fixing this! 🎉
Contributor
Author
|
Jennifer Richards writes:
@jennifer-richards approved this pull request.
This looks ok to me, though should there also be an event for disapproval?
For the initial presentation there is no way to log anything, as the
state is only created AFTER the document as been approved once.
Hmm... when the drafts are updated and then someone disapproves them,
then there would be possibility for making comment.
--
***@***.***
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change os.rename to shutils.move as the submissions and proceedings are on the separate filesystems on the docker image, and this same thing might happen in the real environment in the future.