fix: Don't redirect user to the login page when logging in#6570
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Nov 5, 2023
Merged
fix: Don't redirect user to the login page when logging in#6570rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6570 +/- ##
==========================================
+ Coverage 88.70% 88.85% +0.14%
==========================================
Files 290 284 -6
Lines 40440 40253 -187
==========================================
- Hits 35874 35767 -107
+ Misses 4566 4486 -80
|
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
I think this'll solve the bug, but I'm a little worried about the heavy-handedness of str.replace() for the task. I'd feel better if it were restricted to a prefix. Will the original /accounts/logout removal still work if it's rephrased as a prefix?
…e/recode accordingly Also test with a non-trivial redirect target.
Contributor
Author
|
I'm not overly worried about abuse potential, but since we're really just going from stripping a suffix to stripping a prefix, I went back to your style of filter. |
jennifer-richards
approved these changes
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5876.