Skip to content

feat: Revamp AD dashboard#6534

Merged
rjsparks merged 29 commits intoietf-tools:mainfrom
larseggert:fix-6528
Nov 15, 2023
Merged

feat: Revamp AD dashboard#6534
rjsparks merged 29 commits intoietf-tools:mainfrom
larseggert:fix-6528

Conversation

@larseggert
Copy link
Copy Markdown
Collaborator

@larseggert larseggert commented Oct 24, 2023

Show state queue graphs to logged-in ADs instead of counts and trend arrows.

Fixes #6528
Fixes #6553
Fixes #6608

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2023

Codecov Report

Merging #6534 (4e54054) into main (1b4cb6b) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 84.61%.

❗ Current head 4e54054 differs from pull request most recent head 794cd31. Consider uploading reports for the commit 794cd31 to get more accurate results

@@            Coverage Diff             @@
##             main    #6534      +/-   ##
==========================================
- Coverage   88.88%   88.85%   -0.03%     
==========================================
  Files         285      284       -1     
  Lines       40283    40234      -49     
==========================================
- Hits        35806    35751      -55     
- Misses       4477     4483       +6     
Files Coverage Δ
ietf/doc/views_search.py 89.49% <84.61%> (+0.80%) ⬆️

... and 12 files with indirect coverage changes

Comment thread ietf/doc/views_search.py Outdated
Comment thread ietf/doc/views_search.py Outdated
Comment thread ietf/doc/views_search.py Outdated
@larseggert larseggert marked this pull request as draft October 25, 2023 23:29
@larseggert
Copy link
Copy Markdown
Collaborator Author

Let me do the bigger revamp on this, rather than spending time on the current version.

@larseggert larseggert changed the title fix: Reorder conflict review columns feat: Revamp AD dashboard Nov 4, 2023
@larseggert larseggert marked this pull request as ready for review November 5, 2023 14:16
@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Nov 9, 2023

@larseggert : Is this really ready for review now, or should I wait until next week in case you discover other tweaks during the meeting?

@larseggert
Copy link
Copy Markdown
Collaborator Author

I think it's ready, but it's not urgent

@larseggert larseggert requested a review from rjsparks November 10, 2023 17:45
Copy link
Copy Markdown
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help/states change really should have come in its own PR.

The dashboard also needs a deeper refactor to not use the search to find things, but to go after the information directly from the models. There's too much having to lateral-translate one way and then back the other in the same view.

I'm worried about still more display (and token) transformations creeping in as utility functions, especially lying around in search. These are attractive nuisances and should be factored away so other things don't start using them.

All that said, this is the IESGs page and I won't slow it down.

@rjsparks rjsparks merged commit c36f63b into ietf-tools:main Nov 15, 2023
@larseggert larseggert deleted the fix-6528 branch November 15, 2023 17:32
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants