feat: Render markdown agendas with bs5 styles #6527
Merged
rjsparks merged 7 commits intoietf-tools:mainfrom Oct 30, 2023
Merged
feat: Render markdown agendas with bs5 styles #6527rjsparks merged 7 commits intoietf-tools:mainfrom
rjsparks merged 7 commits intoietf-tools:mainfrom
Conversation
So that the look is consistent with the rest of the datatracker.
rjsparks
approved these changes
Oct 24, 2023
rjsparks
requested changes
Oct 26, 2023
| content_type = content_type.replace("plain", "markdown", 1) | ||
| break | ||
| elif atype[0] == "text/html": | ||
| bytes = render( |
Member
There was a problem hiding this comment.
This is building an HttpResponse object, not a string (thanks to @kesara for spotting it).
Codecov Report
@@ Coverage Diff @@
## main #6527 +/- ##
==========================================
- Coverage 88.85% 88.85% -0.01%
==========================================
Files 284 284
Lines 40253 40253
==========================================
- Hits 35767 35765 -2
- Misses 4486 4488 +2
|
rjsparks
approved these changes
Oct 30, 2023
|
|
||
| // Leave room for fixed-top navbar... | ||
| body { | ||
| body.navbar-offset { |
Member
There was a problem hiding this comment.
This and the change to base seem out of scope for this PR subject. Please make things like this in their own PR going forward.
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the look is consistent with the rest of the datatracker.