Skip to content

feat: Show/edit shepherd for IAB-stream documents #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 2 commits into from
Oct 23, 2023
Merged

feat: Show/edit shepherd for IAB-stream documents #6498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc63f99
feat: Show/edit shepherd for IAB-stream documents (#4810)
pselkirk Oct 19, 2023
fc81bf6
style: Shepherd for IAB documents is called 'IAB shepherd'
pselkirk Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ietf/templates/doc/document_draft.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,11 @@
</td>
</tr>
{% endif %}
{% if doc.stream_id == 'ietf' or doc.stream_id == 'ise' or doc.stream_id == 'irtf' or doc.stream_id == 'editorial' %}
{% if doc.stream_id == 'ietf' or doc.stream_id == 'ise' or doc.stream_id == 'irtf' or doc.stream_id == 'editorial' or doc.stream_id == 'iab' %}
<tr>
<td></td>
<th scope="row">

@rjsparks rjsparks Oct 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the next line (L180) switch on stream_id to say "IAB Shepherd" for iab stream otherwise "Doc Shepherd" please

Document shepherd
{% if doc.stream_id == 'iab' %}IAB shepherd{% else %}Document shepherd{% endif %}
</th>
<td class="edit">
{% if can_edit_stream_info and not snapshot %}
Expand Down