Icons for sidebar collapse/expand#6465
Merged
Merged
Conversation
This change uses [bi-arrow-bar-left](https://icons.getbootstrap.com/icons/arrow-bar-left/) and [bi-arrow-bar-right](https://icons.getbootstrap.com/icons/arrow-bar-right/). This is a minimal change, but changes from . I started off with just changing the open one to use [bi-layout-sidebar](https://icons.getbootstrap.com/icons/layout-sidebar/), which is the mirror of the collapsed icon. I also considered changing the icon that shows when collapsed to [bi-layout-sidebar-text-reverse](https://icons.getbootstrap.com/icons/layout-text-sidebar-reverse/). Both of those seemed less clear than these. Note that the "shown"/"collapsed" classes on these elements appear to be reversed. I didn't touch that.
Collaborator
|
LGTM
If you did want to fix that, I wouldn't mind... |
larseggert
approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #6465 +/- ##
=======================================
Coverage 88.70% 88.71%
=======================================
Files 290 290
Lines 40440 40436 -4
=======================================
Hits 35874 35874
+ Misses 4566 4562 -4 |
rjsparks
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses bi-arrow-bar-left and bi-arrow-bar-right. This is a minimal change, but changes from .
I started off with just changing the open one to use bi-layout-sidebar, which is the mirror of the collapsed icon. I also considered changing the icon that shows when collapsed to bi-layout-sidebar-text-reverse. Both of those seemed less clear than these.
Note that the "shown"/"collapsed" classes on these elements appear to be reversed. I didn't touch that.