Skip to content

fix: Add remote instructions and date/time to interim agenda page#6442

Merged
rjsparks merged 11 commits into
ietf-tools:mainfrom
larseggert:fix-6433
Oct 12, 2023
Merged

fix: Add remote instructions and date/time to interim agenda page#6442
rjsparks merged 11 commits into
ietf-tools:mainfrom
larseggert:fix-6433

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Fixes #6433
Fixes #6249

@codecov

codecov Bot commented Oct 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6442 (1763d74) into main (16f9e0e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6442      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.01%     
==========================================
  Files         290      290              
  Lines       40436    40436              
==========================================
- Hits        35871    35868       -3     
- Misses       4565     4568       +3     

see 2 files with indirect coverage changes

@rjsparks

Copy link
Copy Markdown
Member

This shows whatever time the people created the meeting, but everywhere else we've moved to showing the time in UTC by default and using JS to show options (utc, local, meeting time). This view should do the same.
image

@rjsparks

Copy link
Copy Markdown
Member

We should also put the date and time on the group meetings page.
For future and in-progress sessions, the time should show here somewhere:
image

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see the above comments on the discussion tab)

@larseggert
larseggert requested a review from rjsparks October 11, 2023 07:00

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for continuing to improve things for meeting participants.

I think we need a few more touches before merging this -

at http://localhost:8000/meeting/interim-2023-cbor-16/session/cbor I see:

image

It would be good to put the timezone selectors there as well (instead of the current showing of timezone declared for the meeting), again with default to local (?).

At http://localhost:8000/doc/agenda-interim-2023-cbor-16-cbor-01/ I see:
image

The time happens to be in Local (I think) but the Local cell is not selected so it's not clear what the timezone is until clicking around a bit.

Also, when the Meeting option is pressed, the result is:
image
which says nothing about what timezone that actually is?

@larseggert

larseggert commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator Author

@rjsparks last commit should fix your issues. I couldn't reproduce "Local cell is not selected", it is selected in my dev instance. (Did you yarn legacy:build?)

@larseggert
larseggert requested a review from rjsparks October 12, 2023 07:27
@rjsparks
rjsparks merged commit fa00abf into ietf-tools:main Oct 12, 2023
@larseggert
larseggert deleted the fix-6433 branch October 12, 2023 12:05
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It's counterintuitive that remote participation links are under "Materials" Interim meetings don't show a date and time

2 participants