fix: Deal with different group orders#6394
Conversation
|
Unless I'm missing something this change cannot have fixed the bug. The change may be harmless, but if it actually does something, there's something more broken in the factories to address. The bare calls to GroupFactory make names this way: So that call would have made |
|
Hm. I wasn't actually able to reproduce the bug locally. Let me run the test for a few more hours to see if it kicks in. |
Codecov Report
@@ Coverage Diff @@
## main #6394 +/- ##
=======================================
Coverage 88.68% 88.69%
=======================================
Files 290 290
Lines 40421 40431 +10
=======================================
+ Hits 35848 35860 +12
+ Misses 4573 4571 -2
|
Convinced by @rjsparks comment that there must be something else going on
|
We'll merge this. It might have been better to change what the sreq app does so that the output is deterministic, but the investment would be better made on replacing the sreq app. |
Fixes #6393