Skip to content

feat: Remove document notes from the datatracker#6387

Merged
rjsparks merged 5 commits intoietf-tools:mainfrom
larseggert:feat-6013
Oct 9, 2023
Merged

feat: Remove document notes from the datatracker#6387
rjsparks merged 5 commits intoietf-tools:mainfrom
larseggert:feat-6013

Conversation

@larseggert
Copy link
Copy Markdown
Collaborator

Fixes #6013

@larseggert larseggert marked this pull request as draft September 26, 2023 13:59
@larseggert larseggert changed the title feat: Remove RFC Editor Notes from the datatracker feat: Remove IESG Notes from the datatracker Sep 28, 2023
@larseggert larseggert changed the title feat: Remove IESG Notes from the datatracker feat: Remove document notes from the datatracker Sep 28, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 28, 2023

Codecov Report

Merging #6387 (14afcfd) into main (c5a955d) will decrease coverage by 0.11%.
Report is 26 commits behind head on main.
The diff coverage is n/a.

❗ Current head 14afcfd differs from pull request most recent head 93be190. Consider uploading reports for the commit 93be190 to get more accurate results

@@            Coverage Diff             @@
##             main    #6387      +/-   ##
==========================================
- Coverage   88.81%   88.70%   -0.11%     
==========================================
  Files         290      290              
  Lines       40879    40388     -491     
==========================================
- Hits        36305    35826     -479     
+ Misses       4574     4562      -12     
Files Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/doc/views_draft.py 92.21% <ø> (+0.27%) ⬆️
ietf/iesg/views.py 93.93% <ø> (+0.26%) ⬆️
ietf/nomcom/urls.py 100.00% <ø> (ø)
ietf/nomcom/utils.py 91.42% <ø> (-2.01%) ⬇️
ietf/nomcom/views.py 93.00% <ø> (-1.62%) ⬇️

... and 3 files with indirect coverage changes

@larseggert larseggert marked this pull request as ready for review September 29, 2023 07:44
@rjsparks
Copy link
Copy Markdown
Member

Do we really want to remove the note from the database? (I've been on the fence about this). We have the option of removing the ability to edit/make new ones, but show old ones when they existed.

If we want do want to remove it from the database, do we want to move the existing notes somewhere (a dump kept in long-term offline storage, or shifting them to be comments on the document (using DocEvent)? Or is it ok just to throw the information away?

@larseggert
Copy link
Copy Markdown
Collaborator Author

No, let's keep them in the db. What do I need to change?

@rjsparks
Copy link
Copy Markdown
Member

don't remove the column from the models and remove the migration that came from that change. Then look at the places where you removed how its shown - the emails and all can stay as you've changed them I think, but the html views should show them still if the note is non-empty.

The editing views should all stay removed as the PR currently removes them - if any need to change in the future, the secretariat can[^1] change them using the admin.


^1 : We have a separate issue that the secretariat's access to the admin is spotty and needs tuning.

@larseggert larseggert requested a review from rjsparks October 2, 2023 06:30
@rjsparks rjsparks merged commit 7dbfc02 into ietf-tools:main Oct 9, 2023
@larseggert larseggert deleted the feat-6013 branch October 9, 2023 18:57
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the IESG Note from the IESG writeups tab

3 participants