feat: Remove document notes from the datatracker#6387
feat: Remove document notes from the datatracker#6387rjsparks merged 5 commits intoietf-tools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6387 +/- ##
==========================================
- Coverage 88.81% 88.70% -0.11%
==========================================
Files 290 290
Lines 40879 40388 -491
==========================================
- Hits 36305 35826 -479
+ Misses 4574 4562 -12
|
9cfc602 to
6a301db
Compare
|
Do we really want to remove the note from the database? (I've been on the fence about this). We have the option of removing the ability to edit/make new ones, but show old ones when they existed. If we want do want to remove it from the database, do we want to move the existing notes somewhere (a dump kept in long-term offline storage, or shifting them to be comments on the document (using DocEvent)? Or is it ok just to throw the information away? |
|
No, let's keep them in the db. What do I need to change? |
|
don't remove the column from the models and remove the migration that came from that change. Then look at the places where you removed how its shown - the emails and all can stay as you've changed them I think, but the html views should show them still if the note is non-empty. The editing views should all stay removed as the PR currently removes them - if any need to change in the future, the secretariat can[^1] change them using the admin. ^1 : We have a separate issue that the secretariat's access to the admin is spotty and needs tuning. |
Fixes #6013