fix: State descriptions can have HTML in them, mark them safe#6384
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Sep 26, 2023
Merged
fix: State descriptions can have HTML in them, mark them safe#6384rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6384 +/- ##
=======================================
Coverage 88.69% 88.69%
=======================================
Files 290 290
Lines 40390 40421 +31
=======================================
+ Hits 35823 35852 +29
- Misses 4567 4569 +2
|
Member
|
Whiie this may be better in the short run, it moves us further away from the right place to be. State descriptions (and DocEvent descriptions) should NOT have html in them. If we want this stuff to be marked up, we should use a safer markup language (limited markdown perhaps). Or we should stop trying to mark it up. |
Member
|
To be clear, since state descriptions can only be provided by code or by someone with admin access, we can take this PR, but we really need to squeeze these pockets of html fragments out of the database. |
rjsparks
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.