fix: Enable editing of related liaison statement information#6371
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Sep 25, 2023
Merged
fix: Enable editing of related liaison statement information#6371rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
rjsparks
reviewed
Sep 25, 2023
| try: | ||
| decoded = json.loads(json_data) | ||
| except json.JSONDecodeError as e: | ||
| self.fail('data-pre contained invalid JSON data: %s' % str(e)) |
Member
There was a problem hiding this comment.
This is a little odd. The test is "Does the code that builds the form put JSON in the field". I guess it's better to break of there's something that's not clearly JSON there, but a lot could go in that would survive json.loads that isn't useful.
self.fail outside of something like setUp where you are using it to check that the test framework and factory/fixture data is sane is always a bit of a red flag.
A better test would look to see that the fieid contained the expected data?
Member
There was a problem hiding this comment.
We'll move forward with this and refine it later if needed.
Collaborator
Author
There was a problem hiding this comment.
That pattern exists elsewhere in the tests, so we should fix it everywhere.
rjsparks
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6264