Skip to content

fix: Prevent duplicate HTML IDs on photo page #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 2 commits into from
Sep 22, 2023
Merged

fix: Prevent duplicate HTML IDs on photo page #6356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01370a4
fix: Prevent duplicate HTML IDs on photo page
larseggert Sep 22, 2023
f38b2e2
Just don't slugify the ID.
larseggert Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ietf/templates/group/all_photos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<h1>{{ group_type | upper }} {{ role }} photos</h1>
{% regroup roles|dictsort:"last_initial" by last_initial as alphabet_blocks %}
{% for letter in alphabet_blocks %}
<h2 class="mt-4" {% if letter.grouper|slugify %}id="{{ letter.grouper|slugify }}"{% endif %}>{{ letter.grouper }}</h2>
<h2 class="mt-4" {% if letter.grouper|slugify %}id="{{ letter.grouper }}"{% endif %}>{{ letter.grouper }}</h2>
{% regroup letter.list by person as person_groups %}
{# keep in sync with group_photos.html #}
<div class="mt-0 row row-cols-2 row-cols-sm-2 row-cols-md-3 row-cols-lg-4 row-cols-xl-4 row-cols-xxl-5 g-2">
Expand All @@ -17,4 +17,4 @@ <h2 class="mt-4" {% if letter.grouper|slugify %}id="{{ letter.grouper|slugify }}
{% endfor %}
</div>
{% endfor %}
{% endblock %}
{% endblock %}